[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7408: GEODE-10048: Add framework for Redis events and BLPOP command

[GitBox]

jdeppe-pivotal commented on a change in pull request #7408:
URL: https://github.com/apache/geode/pull/7408#discussion_r824372570



##########
File path: 
geode-for-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##########
@@ -232,7 +236,14 @@ public void channelInactive(ChannelHandlerContext ctx) {
     }
   }
 
-  private void executeCommand(Command command) throws Exception {
+  public void resubmitCommand(Command command) {
+    ChannelHandlerContext ctx =
+        channel.pipeline().context(ByteToCommandDecoder.class.getSimpleName());
+    ctx.fireChannelRead(command);

Review comment:
       99% sure :). I think the only time it might not be the case is when the 
current thread is also the same thread that is associated with the original 
blocking command's ExecutionHandlerContext.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org