mivanac commented on pull request #6909: URL: https://github.com/apache/geode/pull/6909#issuecomment-1071885875
Hi, one of the reasons is that, I was waiting on review of that test for several months, and that was main reason that PR was open for almost 6 months. The other reason is that after modification of that test case, test was always passing, and could not be used to reproduce reported fault (whithout proposed solution). If you want I can create new PR which would include only distributed test, and now I can hope that it will be reviewed by code owners. Regards, Mario ________________________________ Šalje: Udo Kohlmeyer ***@***.***> Poslano: 18. ožujka 2022. 0:19 Prima: apache/geode ***@***.***> Kopija: Mario Ivanac ***@***.***>; Mention ***@***.***> Predmet: Re: [apache/geode] GEODE-9642: Wait for colocation completed at partitioned region initialization (#6909) @mivanac<https://github.com/mivanac> I see that you removed a distributed test from this commit. Was there a reason for the removal of the test? Was it not testing the scenario and adding no benefit to the feature/issue? Was it a valid test and the removal was because the review process was failing you? (which I can see after reviewing the comments). Generally there is a consensus that we would like more tests to prove a feature to work or confirm that it still works. Lack of tests or removal of a test for any reason should raise and eyebrow. Could you please elaborate as to the removal of this test. Generally — Reply to this email directly, view it on GitHub<https://github.com/apache/geode/pull/6909#issuecomment-1071796975>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALSDGHGSA5HXIKVO5PM2ZXTVAO4XLANCNFSM5E45AF7A>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
