nonbinaryprogrammer commented on a change in pull request #7471:
URL: https://github.com/apache/geode/pull/7471#discussion_r833793041
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java
##########
@@ -853,7 +853,8 @@ void recoverPrimary(Set<ServerLocation> excludedServers) {
return;
}
final boolean isDebugEnabled = logger.isDebugEnabled();
- if (queueConnections.getPrimary() != null &&
!queueConnections.getPrimary().isDestroyed()) {
+ if (queueConnections != null && queueConnections.getPrimary() != null
+ && !queueConnections.getPrimary().isDestroyed()) {
Review comment:
Ok I think I did what you described, but please let me know if I
misunderstood what you were suggesting. I think it should be safe to remove the
null check that I previously added, but since it's hard to test I'm not sure.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
