Bill commented on a change in pull request #7303:
URL: https://github.com/apache/geode/pull/7303#discussion_r834669004
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/distributed/HostedLocatorsDUnitTest.java
##########
@@ -54,277 +45,163 @@
* @since GemFire 8.0
*/
@Category({ClientServerTest.class})
-public class HostedLocatorsDUnitTest extends JUnit4DistributedTestCase {
-
- protected static final int TIMEOUT_MILLISECONDS = 5 * 60 * 1000; // 5 minutes
-
- protected transient volatile int locatorPort;
- protected transient volatile LocatorLauncher launcher;
-
- @Override
- public final void postSetUp() throws Exception {
- disconnectAllFromDS();
- }
-
- @Override
- public final void preTearDown() throws Exception {
- disconnectAllFromDS();
- }
+@SuppressWarnings("serial")
+public class HostedLocatorsDUnitTest implements Serializable {
- private String getUniqueLocatorName() {
- String uniqueLocatorName = Host.getHost(0).getHostName() + "_"
- + getUniqueName();
- return uniqueLocatorName;
- }
+ @Rule
+ public ClusterStartupRule clusterStartupRule = new ClusterStartupRule();
Review comment:
can't be private and use the `@Rule` annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
