dschneider-pivotal commented on a change in pull request #7492:
URL: https://github.com/apache/geode/pull/7492#discussion_r836641107
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/execute/FunctionServiceBase.java
##########
@@ -433,4 +437,17 @@ public void fromData(DataInput in) throws IOException,
ClassNotFoundException {
}
}
+ public static <T> Function<T>
identifiableFunction(SerializableConsumerIF<FunctionContext<T>> f) {
+ return new Function<T>() {
+ @Override
+ public String getId() {
Review comment:
Would it be better to fix this in the product by changing the default
Function.getId method to still call getCanonicalName but then check if it
returns null and in that case return class.getName()?
Otherwise users may hit the same issue with the product's default getId
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
