pivotal-jbarrett commented on a change in pull request #7449:
URL: https://github.com/apache/geode/pull/7449#discussion_r837522595



##########
File path: 
geode-core/src/main/java/org/apache/geode/internal/net/NioSslEngine.java
##########
@@ -248,12 +248,24 @@ public ByteBufferSharing wrap(ByteBuffer appData) throws 
IOException {
 
         SSLEngineResult wrapResult = engine.wrap(appData, myNetData);
 
-        if (wrapResult.getHandshakeStatus() == NEED_TASK) {
-          handleBlockingTasks();
+        switch (wrapResult.getStatus()) {
+          case BUFFER_UNDERFLOW:
+            throw new SSLException("Error encrypting data: " + wrapResult);
+          case BUFFER_OVERFLOW:
+            write(channel, myNetData);

Review comment:
       That smells to me like there is a different problem then. Is the input 
buffer to `wrap()` empty and this is just a case on non-blocking IO being 
blocked from writing the output buffer fully?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to