mivanac commented on a change in pull request #7347:
URL: https://github.com/apache/geode/pull/7347#discussion_r837734165



##########
File path: 
geode-core/src/main/java/org/apache/geode/cache/client/internal/pooling/ConnectionManager.java
##########
@@ -71,6 +72,29 @@ Connection borrowConnection(ServerLocation server, long 
acquireTimeout,
       boolean onlyUseExistingCnx)
       throws AllConnectionsInUseException, NoAvailableServersException;
 
+  /**
+   * Borrow an existing idle connection or create a new one to a specific 
server. Fails after one
+   * failed attempt to create a new connection. May cause pool to exceed 
maxConnections by one, if
+   * no connection is available.
+   *
+   * @param serverLocationAndMemberId The server the connection needs to be to.
+   * @param acquireTimeout The amount of time to wait for a connection to 
become available, if
+   *        onlyUseExistingCnx is set to true.
+   * @param onlyUseExistingCnx if true, will not create a new connection if 
none are available.
+   * @return A connection to use.
+   * @throws AllConnectionsInUseException If there is no available connection 
on the desired server,
+   *         and onlyUseExistingCnx is set.
+   * @throws NoAvailableServersException If we can't connect to any server
+   * @throws ServerConnectivityException If finding a connection and creating 
a connection both fail
+   *         to return a connection
+   *
+   */
+  Connection borrowConnection(ServerLocationAndMemberId 
serverLocationAndMemberId,
+      long acquireTimeout,
+      boolean onlyUseExistingCnx)
+      throws AllConnectionsInUseException, NoAvailableServersException;
+
+

Review comment:
       updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to