albertogpz commented on pull request #7391: URL: https://github.com/apache/geode/pull/7391#issuecomment-1082213175
> Has test coverage been added for the changes in this PR? I see that `WanCopyRegionCommandDUnitTest` has been modified, but it's not clear to me if these modifications are just test clean-up or specifically intended to replicate the issue described in the ticket. @DonalEvans Yes, it has been added. Lines 675-678 in WanCopyRegionCommandDUnitTest are checking that no events are left in B's gateway sender to be sent to C (this is something that was happening before the fix because the gateway sender in B was not started). Now gateway sender is started and so the check at the end of test case `testSuccessfulExecution()` will now correctly verify that callbacks are not invoked in B (which would have been provoked that events had been propagated to C). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
