albertogpz commented on pull request #7515:
URL: https://github.com/apache/geode/pull/7515#issuecomment-1084578454


   > For Ping task (which as prerequisite has defined destination endpoint), 
when sending ping message, in case connected endpoint is different than the 
destination endpoint, don't register this new endpoint.
   > ### For all changes:
   > 
   >     * [*] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   > 
   >     * [*] Has your PR been rebased against the latest commit within the 
target branch (typically `develop`)?
   > 
   >     * [*] Is your initial contribution a single, squashed commit?
   > 
   >     * [*] Does `gradlew build` run cleanly?
   > 
   >     * [*] Have you written or updated unit tests to verify your changes?
   > 
   >     * [ ]  If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   Could you please elaborate a bit more on what you are implementing and the 
benefit (or what it is fixing)? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to