upthewaterspout commented on a change in pull request #7512:
URL: https://github.com/apache/geode/pull/7512#discussion_r840078939
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/delta/RemoveByteArrays.java
##########
@@ -53,14 +51,14 @@ public void add(byte[] delta) {
public void serializeTo(DataOutput out) throws IOException {
super.serializeTo(out);
- InternalDataSerializer.writeArrayLength(byteArrays.size(), out);
+ DataSerializer.writePrimitiveInt(byteArrays.size(), out);
Review comment:
Sadly, this is going to make this array size take more bytes on the wire
- writeArrayLength did some compression on on the int, but writePrimativeInt
does not. So maybe we should still use the internal class? Other option would
be `InternalDataSerializer.writeUnsignedVL` - which also compresses the integer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
