jdeppe-pivotal commented on a change in pull request #7478:
URL: https://github.com/apache/geode/pull/7478#discussion_r840749048
##########
File path:
geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/connection/AuthIntegrationTest.java
##########
@@ -117,15 +118,19 @@ private void setupCache(String username, boolean
withSecurityManager) throws Exc
cf.set(LOG_LEVEL, "error");
cf.set(MCAST_PORT, "0");
cf.set(LOCATORS, "");
- if (username != null) {
- cf.set(ConfigurationProperties.GEODE_FOR_REDIS_USERNAME, username);
- }
if (withSecurityManager) {
cf.set(ConfigurationProperties.SECURITY_MANAGER,
SimpleSecurityManager.class.getName());
}
cache = cf.create();
port = AvailablePortHelper.getRandomAvailableTCPPort();
- server = new GeodeRedisServer("localhost", port, (InternalCache) cache);
+
+ TestRedisConfiguration.Builder redisConfigBuilder =
TestRedisConfiguration.builder();
+ redisConfigBuilder.withAddress("localhost").withPort(port).build();
Review comment:
Yes, you're correct.
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##########
@@ -69,13 +69,13 @@
/**
* Constructor for {@code GeodeRedisServer} that will configure the server
to bind to the given
* address and port.
Review comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
