mivanac commented on code in PR #7323: URL: https://github.com/apache/geode/pull/7323#discussion_r843073965
########## geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java: ########## @@ -1160,6 +1169,7 @@ private boolean acquiredPrimaryLock() { try { synchronized (this) { if (isHosting() && (isVolunteering() || isBecomingPrimary())) { + hasBecomePrimary = isBecomingPrimary(); Review Comment: For the case, when we were hosting secondary bucket, and then volunteering for primary, we will check if receivedGatewaySenderStoppedMessage is received. If it is, we trust that curent state of events in bucket is updated, and we do not mark all events as possible duplicates. In case we did not received receivedGatewaySenderStoppedMessage (ungracefull shutdown of member with primary bucket), we will mark all events as possible duplicates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org