jinmeiliao commented on code in PR #7556: URL: https://github.com/apache/geode/pull/7556#discussion_r843285783
########## geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java: ########## @@ -1231,6 +1231,7 @@ long putSubject(Subject subject, long existingUniqueId) { secureLogger.debug("update subject on client proxy {} with uniqueId {}", clientProxy, uniqueId); clientProxy.setSubject(subject); Review Comment: since they use different lock, I will keep it in different methods. ########## geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/MessageDispatcherTest.java: ########## @@ -137,15 +137,15 @@ public void normalRunWillDispatchMessage() throws Exception { @Test Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org