DonalEvans commented on code in PR #7529:
URL: https://github.com/apache/geode/pull/7529#discussion_r843313872
##########
geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GetClusterConfigurationFunction.java:
##########
@@ -27,6 +27,7 @@
public class GetClusterConfigurationFunction implements InternalFunction {
private static final Logger logger = LogService.getLogger();
+ private static final long serialVersionUID = 6332908511113951823L;
Review Comment:
The javadoc on the `Function` interface says
>\* Even though this interface extends Serializable, functions will only be
serialized if they are
>\* not registered. For best performance it is recommended that you
implement {@link #getId()} to
>\* return a non-null identifier and register your function using {@link
>\* FunctionService#registerFunction(Function)} or the cache.xml
<code>function</code> element.
This seems to imply that if the function is registered, the UUID shouldn't
matter, because it's never used. The tricky part here would be that the
function is not being registered on older versions, so the older version would
need to be patched to have the function be registered there too for it to work.
I think this would be the better long-term solution, but possibly not feasible
right now.
At the least, it might be good to have the function be registered in this
version, so that future versions can benefit from the improved performance of
not having to use Java serialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
