gesterzhou commented on code in PR #7569: URL: https://github.com/apache/geode/pull/7569#discussion_r845541641
########## geode-core/src/main/java/org/apache/geode/internal/cache/versions/DiskVersionTag.java: ########## @@ -44,7 +44,7 @@ public void setMemberID(DiskStoreID memberID) { @Override public void replaceNullIDs(VersionSource memberID) { if (getMemberID() == null) { - throw new AssertionError("Member id should not be null for persistent version tags"); + throw new IllegalStateException("Member id should not be null for persistent version tags"); Review Comment: I would rather not to introduce a new Exception class. We can use DiskAccessException here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org