mmartell commented on code in PR #954:
URL: https://github.com/apache/geode-native/pull/954#discussion_r846170170
##########
clicache/integration-test2/Cluster.cs:
##########
@@ -71,7 +73,7 @@ private bool StartLocators()
for (var i = 0; i < locatorCount_; i++)
{
var locator = new Locator(this, new List<Locator>(),
- name_ + "/locator/" + i.ToString(), i == 0);
+ name_ + "/locator/" + i.ToString(), i == 0, allowAttach_);
Review Comment:
I do like the builder pattern. With nearly 30 potential parameters for the
start locator command it seems prudent. Means using it for Server construction
also, for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
