pivotal-jbarrett commented on code in PR #7573:
URL: https://github.com/apache/geode/pull/7573#discussion_r848465884
##########
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderAlertThresholdDUnitTest.java:
##########
@@ -86,17 +86,16 @@ public void testParallelSenderQueueEventsAlertThreshold() {
vm2.invoke(serializableRunnableIF);
vm3.invoke(serializableRunnableIF);
- ArrayList<Integer> v4List =
- (ArrayList<Integer>) vm4.invoke(() -> WANTestBase.getSenderStats("ln",
-1));
- ArrayList<Integer> v5List =
- (ArrayList<Integer>) vm5.invoke(() -> WANTestBase.getSenderStats("ln",
-1));
- ArrayList<Integer> v6List =
- (ArrayList<Integer>) vm6.invoke(() -> WANTestBase.getSenderStats("ln",
-1));
- ArrayList<Integer> v7List =
- (ArrayList<Integer>) vm7.invoke(() -> WANTestBase.getSenderStats("ln",
-1));
+ await().untilAsserted(() -> {
+ List<Integer> v4List = vm4.invoke(() -> WANTestBase.getSenderStats("ln",
-1));
+ List<Integer> v5List = vm5.invoke(() -> WANTestBase.getSenderStats("ln",
-1));
+ List<Integer> v6List = vm6.invoke(() -> WANTestBase.getSenderStats("ln",
-1));
+ List<Integer> v7List = vm7.invoke(() -> WANTestBase.getSenderStats("ln",
-1));
- assertThat((v4List.get(12) + v5List.get(12) + v6List.get(12) +
v7List.get(12)) > 0).as(
- "GatewaySenders Stats should contain number of
EventsExceedingAlertThreshold > 0").isTrue();
+ assertThat((v4List.get(12) + v5List.get(12) + v6List.get(12) +
v7List.get(12)) > 0).as(
+ "GatewaySenders Stats should contain number of
EventsExceedingAlertThreshold > 0")
+ .isTrue();
Review Comment:
I fixed a few of these, not sure how I missed some of these others. Thanks
for pointing them out.
I get what you are saying in the second option but we can't assume that the
stat in any one of those collections is actually greater than 0 but that the
sum of them all is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
