pivotal-jbarrett commented on code in PR #7409:
URL: https://github.com/apache/geode/pull/7409#discussion_r848750664
##########
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java:
##########
@@ -3047,7 +3042,8 @@ private boolean readMessageHeader(ByteBuffer
peerDataBuffer) throws IOException
return false;
}
- private void readMessage(ByteBuffer peerDataBuffer, AbstractExecutor
threadMonitorExecutor) {
+ @VisibleForTesting
Review Comment:
Package private methods don't really need this annotation. Making methods
package private is normal for unit testing. This annotation should be reserved
for public methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
