dschneider-pivotal commented on code in PR #7587: URL: https://github.com/apache/geode/pull/7587#discussion_r850742326
########## geode-core/src/test/java/org/apache/geode/internal/net/BufferPoolTest.java: ########## @@ -15,78 +15,80 @@ package org.apache.geode.internal.net; +import static org.apache.geode.util.internal.GeodeGlossary.GEMFIRE_PREFIX; Review Comment: One is "gemfire." and the other is "geode.". So if we changed this one, for example, to GEODE_PREFIX we would break anyone using the old sys prop name. So although the constant is internal it's value is part of the external contract we have with users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
