jdeppe-pivotal commented on code in PR #7592:
URL: https://github.com/apache/geode/pull/7592#discussion_r850778592


##########
geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/eventing/BlockingCommandListenerTest.java:
##########
@@ -58,7 +58,7 @@ public void testTimeoutIsAdjusted() {
     verify(context, times(1)).resubmitCommand(argumentCaptor.capture());
 
     double timeout = 
Coder.bytesToDouble(argumentCaptor.getValue().getCommandArguments().get(0));
-    assertThat(timeout).isLessThan(1.0D);
+    await().untilAsserted(() -> assertThat(timeout).isLessThan(1.0D));

Review Comment:
   Since `timeout` is only calculated once, this await will not do what you 
want. I think you're better off just putting a sleep before the 
`resubmitCommand()` call. The test is flaky on Windows where the resolution of 
the clock is not very high (I believe the clock only ticks every 15ms) so it 
could be that this runs quickly enough that the timeout does not get 
recalculated with an updated clock time.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to