[GitHub] [geode] demery-pivotal commented on a diff in pull request #7596: GEODE-10242: Generate tail key after all child regions become primary

[GitBox]

demery-pivotal commented on code in PR #7596:
URL: https://github.com/apache/geode/pull/7596#discussion_r857986132


##########
geode-core/src/test/java/org/apache/geode/internal/cache/BucketRegionTest.java:
##########
@@ -61,8 +67,12 @@
 import org.apache.geode.internal.cache.tier.sockets.ConnectionListener;
 import org.apache.geode.internal.statistics.StatisticsClock;
 import org.apache.geode.test.fake.Fakes;
+import org.apache.geode.test.junit.rules.ExecutorServiceRule;
 
 public class BucketRegionTest {
+  @Rule
+  public ExecutorServiceRule executor = new ExecutorServiceRule();

Review Comment:
   It's possible that this rule can work with JUnit 5. Try these two steps:
   - Add 
`testImplementation('org.junit.jupiter:junit-jupiter-migrationsupport')` to 
geode-core's build.gradle file.
   - Add `@EnableRuleMigrationSupport` to the test class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org