mhansonp commented on code in PR #7608:
URL: https://github.com/apache/geode/pull/7608#discussion_r858117120
##########
geode-core/src/distributedTest/java/org/apache/geode/cache/client/ClientServerRegisterInterestsDUnitTest.java:
##########
@@ -224,27 +205,27 @@ public void testClientRegisterInterests() {
Region<String, String> example = clientCache.getRegion(SEPARATOR +
"Example");
assertNotNull("'Example' Region in Client Cache was not found!",
example);
- assertEquals(1, example.size());
+ assertThat(example.size()).isEqualTo(1);
assertTrue(example.containsKey("1"));
- assertEquals("ONE", example.get("1"));
+ assertThat(example.get("1")).isEqualTo("ONE");
Review Comment:
I should add @demery-pivotal that I understand what you are saying, but I
don't agree that you are losing all of the context. The context is there as
soon as you click the stack trace. And better yet, there is better context
because there is less out of context information on the line meaning the other
assertions grouped in.
I think this discussion largely boils down to preference. I have accepted
all of Jake's comments (all of which I agree with as they make the code better,
with the exception of this one). The way I process information and debug, Jakes
suggestion makes this code more complex than it needs to be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
