nabarunnag commented on code in PR #7628:
URL: https://github.com/apache/geode/pull/7628#discussion_r860042767
##########
geode-core/src/main/java/org/apache/geode/internal/cache/FilterProfile.java:
##########
@@ -1846,18 +1846,27 @@ protected void process(ClusterDistributionManager dm) {
}
CacheDistributionAdvisor cda = (CacheDistributionAdvisor)
r.getDistributionAdvisor();
- CacheDistributionAdvisor.CacheProfile cp =
- (CacheDistributionAdvisor.CacheProfile)
cda.getProfile(getSender());
- if (cp == null) { // PR accessors do not keep filter profiles around
- if (logger.isDebugEnabled()) {
- logger.debug(
- "No cache profile to update, adding filter profile message to
queue. Message :{}",
- this);
+ CacheDistributionAdvisor.CacheProfile cp;
+
+ // prevent adding the message to queue after we have processed the
queue
+ // in CreateRegionReplyProcessor.process
+ synchronized (cda) {
Review Comment:
Jinmei, what happens if the CreateRegionMessageReply is processed before the
lock is acquired. Is it possible, does the cache profile in reply has the
information about the registered CQs in server1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
