pivotal-jbarrett commented on code in PR #7381:
URL: https://github.com/apache/geode/pull/7381#discussion_r860246662
##########
geode-core/src/main/java/org/apache/geode/internal/tcp/TCPConduit.java:
##########
@@ -777,18 +776,16 @@ public Connection getConnection(InternalDistributedMember
memberAddress,
// Close the connection (it will get rebuilt later).
getStats().incReconnectAttempts();
- if (conn != null) {
- try {
- if (logger.isDebugEnabled()) {
- logger.debug("Closing old connection. conn={} before
retrying. memberInTrouble={}",
- conn, memberInTrouble);
- }
- conn.closeForReconnect("closing before retrying");
- } catch (CancelException ex) {
- throw ex;
- } catch (Exception ex) {
- // ignored
+ try {
+ if (logger.isDebugEnabled()) {
+ logger.debug("Closing old connection. conn={} before retrying.
memberInTrouble={}",
+ conn, memberInTrouble);
}
+ conn.closeForReconnect("closing before retrying");
+ } catch (CancelException ex) {
+ throw ex;
+ } catch (Exception ex) {
Review Comment:
We can eliminate warnings here by use the `ignored` variable name rather
than comment.
```java
} catch (Exception ignored) {
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
