pivotal-jbarrett commented on code in PR #7515:
URL: https://github.com/apache/geode/pull/7515#discussion_r861134316
##########
geode-core/src/test/java/org/apache/geode/distributed/internal/ServerLocationTest.java:
##########
@@ -43,5 +43,7 @@ public void
objectCreatedWithCopyConstructorwhenComparedToOrigin_isEqual() {
final ServerLocation serverLocation2 = new ServerLocation(serverLocation1);
assertThat(serverLocation1).isEqualTo(serverLocation2);
+ assertThat(serverLocation1.getRequiresCredentials())
+ .isEqualTo(serverLocation2.getRequiresCredentials());
Review Comment:
I meant that in the constructor if statement determines how the value is set
but there is only one test for this constructor. There should be two tests, one
that exercised the branch then block and one that does not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
