DonalEvans commented on code in PR #7633:
URL: https://github.com/apache/geode/pull/7633#discussion_r861977574


##########
geode-assembly/src/acceptanceTest/java/org/apache/geode/cache/wan/SeveralGatewayReceiversWithSamePortAndHostnameForSendersTest.java:
##########
@@ -258,7 +258,8 @@ public void 
testPingsToReceiversWithSamePortAndHostnameForSendersUseOnlyOneMoreC
 
     await().untilAsserted(() -> assertThat(getSenderPoolDisconnects(vm1, 
senderId)).isEqualTo(0));
 
-    await().untilAsserted(() -> assertThat(getSenderPoolConnects(vm1, 
senderId)).isEqualTo(4));
+    await().untilAsserted(
+        () -> assertThat(getSenderPoolConnects(vm1, 
senderId)).isLessThanOrEqualTo(4));

Review Comment:
   But the assertion is in an `await()` so it gets checked repeatedly (every 50 
ms by default) until the await times out (which takes 5 minutes). So it seems 
like the time we're checking the stat can't be the reason.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to