jchen21 commented on code in PR #7639:
URL: https://github.com/apache/geode/pull/7639#discussion_r864047176
##########
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java:
##########
@@ -1867,6 +1877,12 @@ void shutdownMessageReceived(InternalDistributedMember
theId, String reason) {
handleManagerDeparture(theId, false, reason);
}
+ long getNonLocatorViewMembers() {
+ return getViewMembers().stream()
Review Comment:
I think instead of `getViewMembers()`, it is better to use
`distribution.getMembersNotShuttingDown()` to exclude the members that are
shutting down. Please see `getOtherDistributionManagerIds()` and
`getOtherNormalDistributionManagerIds()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
