jinmeiliao commented on code in PR #7666:
URL: https://github.com/apache/geode/pull/7666#discussion_r867300041


##########
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java:
##########
@@ -170,6 +171,8 @@ public ResultModel createRegion(
           help = CliStrings.CREATE_REGION__OFF_HEAP__HELP) Boolean offHeap,
       @CliOption(key = CliStrings.CREATE_REGION__PARTITION_RESOLVER,
           help = CliStrings.CREATE_REGION__PARTITION_RESOLVER__HELP) String 
partitionResolver,
+      @CliOption(key = CliStrings.CREATE_REGION__PARTITION_LISTENER,
+          help = CliStrings.CREATE_REGION__PARTITION_LISTENER__HELP) String 
partitionListener,

Review Comment:
   I think a better example is the `cacheListner` parameter, it uses 
ClassName[] as the type. Since the listener is a `Declarable`, the `ClassName` 
type allows the user to specify the initialization values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to