demery-pivotal commented on code in PR #7705:
URL: https://github.com/apache/geode/pull/7705#discussion_r876371862
##########
geode-core/src/main/java/org/apache/geode/metrics/internal/InternalDistributedSystemMetricsService.java:
##########
@@ -227,6 +227,7 @@ private void clearAndCloseMeterRegistry() {
new HashSet<>(meterRegistry.getRegistries())
.forEach(meterRegistry::remove);
+ meterRegistry.clear();
Review Comment:
At the moment, every meter we add uses the default `close()`, which does
nothing.
That said, I don't want to _count_ on meters doing nothing during `close()`.
So I'll change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
