pivotal-jbarrett commented on PR #7688: URL: https://github.com/apache/geode/pull/7688#issuecomment-1135041227
> You may have already checked into this - it looks like the old getString method did not return the exact same name as the constant in some cases. It looks like it was only used in log and exception messages, so I think the fact that you changed the value should be ok. Yup, exactly my thinking. Also, by making it an `enum` it avoids the scenario where one might not have a name, the id was reused, or the last ID was not correctly updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org