jchen21 commented on code in PR #7730:
URL: https://github.com/apache/geode/pull/7730#discussion_r887245832
##########
geode-assembly/src/upgradeTest/java/org/apache/geode/session/tests/TomcatSessionBackwardsCompatibilityTestBase.java:
##########
@@ -105,7 +108,10 @@ protected void startServer(String name, String classPath,
int locatorPort) throw
}
protected void startLocator(String name, String classPath, int port) throws
Exception {
- locatorDir = tempFolder.newFolder("locator").getPath();
+ File locatorFile = new File("locator_dir_" +
this.getClass().getSimpleName() + "_"
+ + testName.getMethodName().replace("[", "").replace("]", ""));
Review Comment:
I am not sure what future param will look like. It could be anything as long
as the syntax allows for the param. I would leave it for future work. Perhaps
someone who introduces a param that has invalid file system character has to
handle it.
The purpose of this change is to keep the logs in case of a test failure.
And in case of multiple log files, we should be able to locate the logs based
on the test class, method and param. Currently, the logs are in a temp folder
which would be automatically deleted at the end of the test, even if there is a
failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
