onichols-pivotal commented on code in PR #7763:
URL: https://github.com/apache/geode/pull/7763#discussion_r889046615
##########
ci/scripts/shared_utilities.sh:
##########
@@ -84,12 +84,18 @@ get-full-version() {
}
get_geode_pr_exclusion_dirs() {
- local exclude_dirs=".github ci dev-tools etc geode-book geode-docs
CODEOWNERS"
+ local exclude_dirs=".github ci dev-tools etc geode-book geode-docs"
echo "${exclude_dirs}"
}
+get_geode_pr_exclusion_files() {
+ local exclude_files="CODEOWNERS .gitignore .gitattributes .travis.yml
CODEWATCHERS COMMITWATCHERS .asf.yaml CODE_OF_CONDUCT.md README.md TESTING.md"
+ echo "${exclude_files}"
+}
+
is_source_from_pr_testable() {
- if [[ $# -ne 2 ]]; then
+ set -x
+ if [[ $# -ne 3 ]]; then
>&2 echo "Invalid args. Try ${0} \"<repo_path>\" \"<list of exclusion
dirs>\""
Review Comment:
usage message should mention the new required arg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
