pivotal-jbarrett commented on code in PR #7751:
URL: https://github.com/apache/geode/pull/7751#discussion_r889259544
##########
geode-core/src/test/java/org/apache/geode/internal/monitoring/executor/AbstractExecutorGroupJUnitTest.java:
##########
@@ -104,7 +104,7 @@ public void handleExpiry(long stuckTime, Map<Long,
ThreadInfo> map) {
threadIds.add(blockedThread.getId());
threadIds.add(blockingThread.getId());
String threadReport = executor.createThreadReport(60000,
- ThreadsMonitoringProcess.createThreadInfoMap(threadIds));
+ ThreadsMonitoringProcess.createThreadInfoMap(threadIds, true,
true));
Review Comment:
I find it confusing that the only unit test to change is one that isn't
related to the changed unit. Please add tests to the
`ThreadsMonitoringProcessJUnitTest`. Please rename this test and
`ThreadsMonitoringProcessJUnitTest` to conform to the current naming
conventions. Please update both to use JUnit 5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
