DonalEvans commented on PR #7721: URL: https://github.com/apache/geode/pull/7721#issuecomment-1146480015
> I think this should have tests associated with it. If we are explicitly catching and exception and optionally ignoring it there should be tests that cover both cases. I'm going to need some help with writing a test that consistently hits the race condition where the `checkExecutor` is shut down and then attempts to execute something. I wasn't able to reproduce the failure in 2000 runs of the distributed test that originally hit it, and making a unit test for it seems extremely difficult as there is very little visibility into the methods that would need to be stubbed/modified in order to ensure things happen in the order we want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
