albertogpz commented on code in PR #7715:
URL: https://github.com/apache/geode/pull/7715#discussion_r904097756
##########
geode-core/src/main/java/org/apache/geode/internal/offheap/MemoryAllocatorImpl.java:
##########
@@ -239,11 +230,19 @@ private MemoryAllocatorImpl(final
OutOfOffHeapMemoryListener oooml,
this.stats.incMaxMemory(freeList.getTotalMemory());
this.stats.incFreeMemory(freeList.getTotalMemory());
- updateNonRealTimeStatsExecutor =
- LoggingExecutors.newSingleThreadScheduledExecutor("Update Freelist
Stats thread");
- updateNonRealTimeStatsFuture =
-
updateNonRealTimeStatsExecutor.scheduleAtFixedRate(freeList::updateNonRealTimeStats,
0,
- updateOffHeapStatsFrequencyMs, TimeUnit.MILLISECONDS);
+ this.updateOffHeapStatsFrequencyMs = updateOffHeapStatsFrequencyMs;
+
+ if (nonRealTimeStatsUpdaterSupplier == null) {
+ nonRealTimeStatsUpdater = new
NonRealTimeStatsUpdater(freeList::updateNonRealTimeStats);
+ } else {
+ nonRealTimeStatsUpdater = nonRealTimeStatsUpdaterSupplier.get();
+ }
+ }
+
+ void start() {
+ if (nonRealTimeStatsUpdater != null) {
Review Comment:
I agree. As I was too quick to merge the PR, should I open a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
