mivanac commented on code in PR #7845:
URL: https://github.com/apache/geode/pull/7845#discussion_r964521537
##########
geode-core/src/test/java/org/apache/geode/internal/cache/BucketRegionQueueJUnitTest.java:
##########
@@ -191,6 +191,49 @@ public void
testGetElementsMatchingWithParallelGatewaySenderQueuePredicatesAndSo
assertEquals(objects, Arrays.asList(event2, event4));
}
+ @Test
+ public void
testGetElementsMatchingWithParallelGatewaySenderQueuePredicatesObjectReadNullDoesNotThrowException()
+ throws ForceReattemptException {
+
ParallelGatewaySenderHelper.createParallelGatewaySenderEventProcessor(this.sender);
+
+ TransactionId tx1 = new TXId(null, 1);
+ TransactionId tx2 = new TXId(null, 2);
+ TransactionId tx3 = new TXId(null, 3);
+
+ GatewaySenderEventImpl event1 = createMockGatewaySenderEvent(1, tx1,
false);
+ GatewaySenderEventImpl eventNotInTransaction1 =
createMockGatewaySenderEvent(2, null, false);
+ GatewaySenderEventImpl event2 = createMockGatewaySenderEvent(3, tx2,
false);
+ GatewaySenderEventImpl event3 = null; // createMockGatewaySenderEvent(4,
tx1, true);
+ GatewaySenderEventImpl event4 = createMockGatewaySenderEvent(5, tx2, true);
+ GatewaySenderEventImpl event5 = createMockGatewaySenderEvent(6, tx3,
false);
+ GatewaySenderEventImpl event6 = createMockGatewaySenderEvent(7, tx3,
false);
+ GatewaySenderEventImpl event7 = createMockGatewaySenderEvent(8, tx1, true);
+
+ this.bucketRegionQueue
+
.cleanUpDestroyedTokensAndMarkGIIComplete(InitialImageOperation.GIIStatus.NO_GII);
+
+ this.bucketRegionQueue.addToQueue(1L, event1);
+ this.bucketRegionQueue.addToQueue(2L, eventNotInTransaction1);
+ this.bucketRegionQueue.addToQueue(3L, event2);
+ this.bucketRegionQueue.addToQueue(4L, event3);
+ this.bucketRegionQueue.addToQueue(5L, event4);
+ this.bucketRegionQueue.addToQueue(6L, event5);
+ this.bucketRegionQueue.addToQueue(7L, event6);
+ this.bucketRegionQueue.addToQueue(8L, event7);
+
+ Predicate<GatewaySenderEventImpl> hasTransactionIdPredicate =
+ ParallelGatewaySenderQueue.getHasTransactionIdPredicate(tx1);
+ Predicate<GatewaySenderEventImpl> isLastEventInTransactionPredicate =
+ ParallelGatewaySenderQueue.getIsLastEventInTransactionPredicate();
+
when(bucketRegionQueue.getValueInVMOrDiskWithoutFaultIn(4L)).thenReturn(null);
+ List<Object> objects =
this.bucketRegionQueue.getElementsMatching(hasTransactionIdPredicate,
+ isLastEventInTransactionPredicate);
+
+ assertEquals(2, objects.size());
+ assertEquals(objects, Arrays.asList(new Object[] {event1, event7}));
Review Comment:
Please replace all with AssertJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
