WeijieEST commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972577636
##########
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##########
@@ -443,7 +443,7 @@ public void testIncompleteColocation() throws
UnknownHostException {
* lmm, it will prevent a bucket move
*/
@Test
- public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationBothEnforceLocalMaxMemory() throws
UnknownHostException {
Review Comment:
The test case was changed for several reasons.
- Test cases are renamed to make them a group together with the newly added
test case(see below description about the test group).
- Add MB to data size so the log will print the model with correct data size.
- Some comments are chanegd, most to help understand the test case better,
and the last comment was wrong.
Description about the test group
The first case test that both of the 2 regions are eviction disabled(this
was tested before),
the second and third test cases test one region is eviction enabled,
the second test case tests the none eviction region memory full(this was
not tested before),
the third test case tests the eviction region memory full(this was
tested before but it should be failed if the test condition was set properly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
