skysanjay commented on PR #7886:
URL: https://github.com/apache/geode/pull/7886#issuecomment-2475320375
Thank Sai for being patient about proposed changes based on what I
could see and reproduce at first sight, however I was certain that there
are broader missing details to me. I see a need for some level of
refactoring to tests otherwise it is an endless chase.
Is there a way I can ensure build behavior is the same on my local or
central server against the PR's ? or Other ways to help out this project ?
On Tue, Nov 12, 2024 at 11:50 AM Sai Boorlagadda ***@***.***>
wrote:
> Thanks @skysanjay <https://github.com/skysanjay> for your contributions.
> I have re-ran the unit tests on develop pipeline and looks like this
> particular test isnt failing. The two tests that were failing are as below
> (see the pipeline here
>
<https://github.com/apache/geode/actions/runs/11787261644/job/32841448763?pr=7887>
> )
>
> WanCopyRegionFunctionServiceTest >
concurrentExecutionsDoesNotExceedMaxConcurrentExecutions() FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
defined as a lambda expression in
org.apache.geode.cache.wan.internal.WanCopyRegionFunctionServiceTest
> expected: 4
> but was: 3 within 5 minutes.
> at
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
> at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
> at
org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:769)
> at
org.apache.geode.cache.wan.internal.WanCopyRegionFunctionServiceTest.concurrentExecutionsDoesNotExceedMaxConcurrentExecutions(WanCopyRegionFunctionServiceTest.java:216)
> Caused by:
> org.opentest4j.AssertionFailedError:
> expected: 4
> but was: 3
> at
sun.reflect.GeneratedConstructorAccessor9.newInstance(Unknown Source)
> at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
org.apache.geode.cache.wan.internal.WanCopyRegionFunctionServiceTest.lambda$concurrentExecutionsDoesNotExceedMaxConcurrentExecutions$20(WanCopyRegionFunctionServiceTest.java:217)
> WanCopyRegionFunctionServiceTest >
severalExecuteWithDifferentRegionOrSenderAreAllowed() FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
defined as a lambda expression in
org.apache.geode.cache.wan.internal.WanCopyRegionFunctionServiceTest
> expected: 5
> but was: 3 within 5 minutes.
> at
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
> at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
> at
org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:769)
> at
org.apache.geode.cache.wan.internal.WanCopyRegionFunctionServiceTest.severalExecuteWithDifferentRegionOrSenderAreAllowed(WanCopyRegionFunctionServiceTest.java:179)
> Caused by:
> org.opentest4j.AssertionFailedError:
> expected: 5
> but was: 3
> at
sun.reflect.GeneratedConstructorAccessor9.newInstance(Unknown Source)
> at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
org.apache.geode.cache.wan.internal.WanCopyRegionFunctionServiceTest.lambda$severalExecuteWithDifferentRegionOrSenderAreAllowed$17(WanCopyRegionFunctionServiceTest.java:180)
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/geode/pull/7886#issuecomment-2469697994>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AJXWIDVLCOUM3EKK3KKCZ4L2AGM2RAVCNFSM6AAAAABRPJWHE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZGY4TOOJZGQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
