JinwooHwang-SAS commented on code in PR #7905:
URL: https://github.com/apache/geode/pull/7905#discussion_r2290608467
##########
geode-core/src/test/java/org/apache/geode/internal/size/ObjectSizerJUnitTest.java:
##########
@@ -33,13 +34,23 @@ public void test() throws Exception {
assertEquals(roundup(OBJECT_SIZE), ObjectGraphSizer.size(new
TestObject3()));
assertEquals(roundup(OBJECT_SIZE * 2 + REFERENCE_SIZE),
ObjectGraphSizer.size(new TestObject3(), true));
- assertEquals(roundup(OBJECT_SIZE + REFERENCE_SIZE),
ObjectGraphSizer.size(new TestObject4()));
- assertEquals(roundup(OBJECT_SIZE + REFERENCE_SIZE) + roundup(OBJECT_SIZE +
4),
+ if (SystemUtils.isAzulJVM()) {
+ assertEquals(roundup(OBJECT_SIZE + REFERENCE_SIZE + 8),
ObjectGraphSizer.size(new TestObject4()));
Review Comment:
As you can see in lines 35-36, OBJECT_SIZE and REFERENCE_SIZE are consistent
whether it's Azul or not: assertEquals(roundup(OBJECT_SIZE * 2 +
REFERENCE_SIZE),
ObjectGraphSizer.size(new TestObject3(), true));
That's why we cannot change those for Azul.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
