gaussianrecurrence opened a new pull request, #6737:
URL: https://github.com/apache/geode/pull/6737
- Previously when you only specified --dir option the PID was read from
the member workDir and the status request was attempted to solved by
using the attachment API, and after that JMX interface.
But given only --dir was specified the controller resolving the
request should be FileProcessController instead.
- Logic has been changed for both servers and locators to always use
FileProcessConroller whenever only --dir flag is specified.
- Added an UT to verify new code.
- Modified several ITs to verify the new behaviour.
- Deleted the following ITs which no longer apply with the new logic:
* statusWithEmptyPidFileThrowsIllegalArgumentException
* statusWithEmptyWorkingDirectoryReturnsNotRespondingWithDetails
* statusWithStalePidFileReturnsNotResponding
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [X] Have you written or updated unit tests to verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
