leonfin commented on PR #7930:
URL: https://github.com/apache/geode/pull/7930#issuecomment-3316035279
hi @JinwooHwang I don't see any specific issues. Here are just some sanity
checks with AI review for this branch diff vs develop branch. My only concern
would be if we have any backward serialization compatibility issues with
previous GEODE 1.15.1/2. But it would require to do integration test I guess.
Potential Issues Found
1. Groovy VM Plugin Cache Corruption
(build-tools/geode-annotation-processor/build.gradle:44)
- Multiple commits address Groovy plugin initialization errors
- Workaround added in GradleBuildWithGeodeCoreAcceptanceTest.java:78-93
using --rerun-tasks and clean
- Root cause: Gradle daemon caching corrupted plugin state
2. Serialization Changes (geode-core/src/integrationTest/resources/):
- Data serialization baselines updated for Java 17
- Multiple classes show different fromData/toData byte counts
- Could cause compatibility issues with older clients
3. Disabled Warnings:
- Added -Xlint:-removal, -Xlint:-deprecation, -Xlint:-unchecked
- Masks potential API usage issues that need addressing
4. Javadoc Configuration:
- Changed from strict HTML checking (-Xwerror) to lenient
(-Xdoclint:none)
- May hide documentation issues
5. Test Exclusion (geode-core/build.gradle:413-416):
- UnitTestDoclet.java excluded due to removed com.sun.javadoc API
- Test coverage potentially reduced
6. JAXB Dependencies (geode-assembly/build.gradle:243-246):
- Added manually since removed from JDK 11+
- May need verification for runtime behavior
Recommendations
1. Monitor Groovy plugin stability - consider upgrading Gradle/Groovy
versions
2. Test serialization compatibility with existing deployments
3. Gradually remove warning suppressions and fix underlying issues
4. Update or replace UnitTestDoclet for Java 17 compatibility
5. Verify JAXB functionality in distributed tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
