raboof commented on PR #7930: URL: https://github.com/apache/geode/pull/7930#issuecomment-3337300060
> The good news is that you don't need to worry at all. These files are actually just test baselines that our serialization analysis framework uses to track the bytecode size of serialization methods. Think of them as a safety net to catch any unintended changes that could break compatibility. > > When we upgraded to Java 17, the JVM started generating more efficient bytecode for the exact same serialization logic. So while the numbers in these files changed (usually by just 1-3 bytes per method), the actual wire protocol and data format that gets sent over the network hasn't changed at all. OK, that seems to match the description in e.g. https://issues.apache.org/jira/browse/GEODE-4749 , though I'm confused why we're testing this at all if we're ok with changing the 'sanctioned' data. I don't feel entirely qualified to judge the correctness of this change, but I have no objections anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
