sboorlagadda opened a new pull request, #7939: URL: https://github.com/apache/geode/pull/7939
This commit addresses RAT (Release Audit Tool) failures that occur when IDE-generated bin/ directories are present in the workspace. The issue was caused by a missing exclusion pattern that should have been included during the build system refactoring in May 2022. Root Cause Analysis: - In April 2017, **/bin/** exclusion was added to RAT configuration (commit 4a09e88b69) - Later removed due to legitimate bin/ folders in source tree (commit 39c72b2046) - During May 2022 build system refactoring (commit 509c0c6c91), the RAT configuration was moved from gradle/rat.gradle to build-tools/scripts/src/main/groovy/geode-rat.gradle - The **/bin/** exclusion pattern was inadvertently omitted from the new configuration Problem: - IDEs (Eclipse, IntelliJ) generate bin/ directories containing compiled classes, test resources, and other build artifacts - These files lack Apache license headers and cause RAT failures - The .gitignore already excludes bin/ folders, indicating they are build artifacts Solution: - Add '**/bin/**' exclusion pattern to RAT configuration - This prevents RAT from scanning IDE-generated build artifacts - Consistent with existing exclusions for other build directories (**/build/**) - Aligns with .gitignore patterns that already exclude bin/ folders Testing: - Verified RAT passes with and without bin/ directories present - Confirmed exclusion works for files without license headers in bin/ folders - No impact on legitimate source files that require license headers This fix prevents future RAT failures for developers using IDEs that generate bin/ directories during normal development workflow. <!-- Thank you for submitting a contribution to Apache Geode. --> <!-- In order to streamline review of your contribution we ask that you ensure you've taken the following steps. --> ### For all changes, please confirm: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
