JinwooHwang commented on code in PR #7926:
URL: https://github.com/apache/geode/pull/7926#discussion_r2382877931
##########
geode-assembly/build.gradle:
##########
@@ -387,24 +408,78 @@ tasks.register('gfshDepsJar', Jar) {
}
}
+// Extract legacy Tomcat 6 jars needed only to satisfy Javadoc for old session
manager classes
+// (LifecycleSupport, SerializablePrincipal) without altering runtime
dependencies.
+def legacyTomcatDir = "$buildDir/legacyTomcat"
+tasks.register('extractLegacyTomcatForJavadoc') {
+ description = 'Extracts legacy Tomcat catalina jars for Javadoc symbol
resolution.'
+ outputs.dir(legacyTomcatDir)
+ dependsOn configurations.webServerTomcat6
+ doLast {
+ delete legacyTomcatDir
+ copy {
+ from { zipTree(configurations.webServerTomcat6.singleFile) }
+ // Include the full Tomcat 6 lib set so packages like
org.apache.catalina.ha.session
Review Comment:
Hi @sboorlagadda,
Thanks for pointing that out—excellent observation. I’ll take a step back
and re-evaluate my initial approach. Your thoughtful feedback is much
appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
