leonfin commented on code in PR #7940:
URL: https://github.com/apache/geode/pull/7940#discussion_r2471599781
##########
geode-gfsh/build.gradle:
##########
@@ -84,22 +86,65 @@ dependencies {
//Spring shell is used by the gfsh cli. It's unclear why we can exclude
//So many transitive dependencies - are these really optional?
//GfshCommand is a public API class that depends on spring shell
- api('org.springframework.shell:spring-shell') {
+ // Spring Shell 3.x uses spring-shell-starter (Spring 6.x migration)
+ api('org.springframework.shell:spring-shell-starter') {
exclude module: 'aopalliance'
exclude module: 'asm'
exclude module: 'cglib'
exclude module: 'guava'
exclude module: 'spring-aop'
exclude module: 'spring-context-support'
- exclude module: 'spring-core'
}
+ // spring-aop is needed in system classpath for Spring context component
scanning
+ // It was excluded from spring-shell-starter above, so add it explicitly
+ implementation('org.springframework:spring-aop')
+
acceptanceTestImplementation(project(':geode-junit'))
acceptanceTestRuntimeOnly(project(':geode-log4j'))
}
+// Exclude obsolete test files that test deleted Spring Shell 1.x converter
classes
Review Comment:
should these tests be removed instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
