JinwooHwang commented on PR #7953: URL: https://github.com/apache/geode/pull/7953#issuecomment-3616772755
Thank you so much for jumping in to review this, @leonfin. I really appreciate you taking the time—especially when other reviewers were unavailable. The property name must be `locators` (plural), not `locator` (singular), because that's the actual property name defined in the Geode configuration system. ### Evidence from Codebase History From the very beginning (commit **1709e627a8**, June 29, 2015), `DistributionConfig.java` has defined: ```java public static final String LOCATORS_NAME = "locators"; public static final String LOCATOR_WAIT_TIME_NAME = "locator-wait-time"; public static final String START_LOCATOR_NAME = "start-locator"; public static final String REMOTE_LOCATORS_NAME = "remote-locators"; ``` Notice that all locator-related properties use either **plural** (`locators`, `remote-locators`) or **hyphenated** (`locator-wait-time`, `start-locator`) forms. There has **never** been a `"locator"` (singular, standalone) property in the codebase. ### The Documentation Error When the documentation was first consolidated in commit **ccc2fbda40** (October 4, 2016), someone accidentally changed `locators=` to `locator=` (removing the 's'). This error has existed in the documentation for almost 9 years, but the code has always required `locators` (plural). I found this while reviewing the documentation for the upcoming 2.0 release. This PR corrects that long-standing mistake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
