JinwooHwang commented on PR #7975:
URL: https://github.com/apache/geode/pull/7975#issuecomment-3723440398
@sboorlagadda, Thanks for the review! Verified!
I've confirmed that no other modules use log4j-core::tests or
log4j-core::test-sources. Here's the evidence:
1. grep -rn "::test" --include="*.gradle" .
2. grep -rn "log4j-core-test" --include="*.gradle" .
./geode-log4j/build.gradle:84: // Log4j 2.20.0+ moved test utilities to
log4j-core-test with new package names:
./geode-log4j/build.gradle:87: // log4j-core-test 2.25.3 transitively
depends on assertj-core 3.27.3, but Geode's
./geode-log4j/build.gradle:90:
integrationTestImplementation('org.apache.logging.log4j:log4j-core-test') {
We're ready to merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]