utafrali commented on code in PR #8140:
URL: https://github.com/apache/geode/pull/8140#discussion_r4400890221
##########
build-tools/geode-dependency-management/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraints.groovy:
##########
@@ -201,6 +203,10 @@ class DependencyConstraints {
api(group: 'org.bouncycastle', name: 'bcprov-jdk18on', version:
get('bouncycastle.version'))
// GEODE-10681: Pin hibernate-validator to a fixed version
api(group: 'org.hibernate.validator', name: 'hibernate-validator',
version: get('hibernate-validator.version'))
+ // GEODE-10687: Pin ASM (transitive via Jetty) to a fixed version
Review Comment:
Only `asm`, `asm-commons`, and `asm-tree` are pinned here, which matches
what appears in the classpath fixture files. If Jetty or another transitive
ever pulls in `asm-analysis` or `asm-util`, they would not be covered by this
pin. Worth noting in the JIRA ticket so the next person doing an ASM bump knows
to check those modules too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
