matrei commented on code in PR #14904:
URL: https://github.com/apache/grails-core/pull/14904#discussion_r2205223043
##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/publishing/GrailsPublishGradlePlugin.groovy:
##########
@@ -178,12 +179,12 @@ Note: if project properties are used, the properties must
be defined prior to ap
projectPluginManager.apply(MavenPublishPlugin)
boolean localSigning = false
+ String signingKeyId = project.findProperty('signing.keyId') ?:
System.getenv('SIGNING_PASSPHRASE')
if (isRelease) {
- String signingKeyId = project.findProperty('signing.keyId') ?:
System.getenv('SIGNING_KEY')
extraPropertiesExtension.setProperty('signing.keyId', signingKeyId)
String secringFile =
project.findProperty('signing.secretKeyRingFile') ?:
System.getenv('SIGNING_KEYRING')
if (!secringFile) {
- project.logger.info("No keyring file has been specified.
Assuming the use of local gpgCommand instead.")
+ project.logger.lifecycle("No keyring file (SIGNING_KEYRING)
has been specified. Assuming the use of local gpgCommand to sign instead.")
Review Comment:
Align on single quotes for strings?
##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/publishing/GrailsPublishGradlePlugin.groovy:
##########
@@ -426,12 +438,23 @@ Note: if project properties are used, the properties must
be defined prior to ap
// The sign task does not properly setup dependencies, see
https://github.com/gradle/gradle/issues/26091
project.tasks.withType(Sign).configureEach {
it.dependsOn(project.tasks.withType(Jar))
+ it.doFirst {
+ if (!signingKeyId) {
+ throw new GradleException("A signing key is
required to sign a release. Set GRAILS_PUBLISH_RELEASE=false to bypass
signing.")
Review Comment:
Align on single quotes for strings?
##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/publishing/GrailsPublishGradlePlugin.groovy:
##########
@@ -282,6 +283,17 @@ Note: if project properties are used, the properties must
be defined prior to ap
}
}
}
+ } else {
+ // always define the test case repo if its set since it's
a local publish
Review Comment:
Suggestion:
```groovy
// This is a local publish. Add the test case repository if it's defined on
the extension.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@grails.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
