jdaugherty commented on code in PR #14895:
URL: https://github.com/apache/grails-core/pull/14895#discussion_r2207552425


##########
build.gradle:
##########
@@ -86,6 +88,12 @@ subprojects {
     }
 
     apply from: 
rootProject.layout.projectDirectory.file('gradle/dependency-licenses.gradle')
+
+    normalization {
+        runtimeClasspath {
+            ignore '**/grails.build.info'

Review Comment:
   In this case, I am contemplating ditching the date and adding just the 
version.  For now, the change you made is perfect!
   
   For the build always being reproducible... setting SOURCE_DATE_EPOCH will 
make it always reproducible... the issue for us is there are multiple entry 
points to the GSP compiler.  Gradle is one of those entrypoints, but a running 
application in dev mode is also one.  Historically the caching was done in the 
compiler itself by setting the date of the compile on the generated class.  
Setting that env variable tells the compiler do not compile files unless they 
have changed after that date - which could be problematic if that date is set.  
I think we can get to the point where reproducible is not opt
   in, but for now we have other tasks to solve.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@grails.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to